Pre-work launcher refactoring #278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icex2
force-pushed
the
pre-work-launcher-refactoring
branch
from
fcb7e82 to
5330802
Compare
This was referenced Jan 29, 2024
icex2
force-pushed
the
pre-work-launcher-refactoring
branch
from
5330802 to
8eef489
Compare
willxinc
approved these changes
Jan 31, 2024
Collaborator
willxinc
left a comment
willxinc
left a comment
There was a problem hiding this comment.
Looks good to me aside from the formatting issue in Module.mk
The avs import changes could probably be squashed into 1 diff if possible.
added 3 commits
January 31, 2024 22:24
This has been a source of common error in the past. It is known that most, or even all, games run into various issues when not run with elevated privileges.
Use this to share helpers or other extensions to the original avs API across modules. Start with including error codes to readable strings to improve velocity on AVS API error analysis.
icex2
force-pushed
the
pre-work-launcher-refactoring
branch
2 times, most recently
from
4b93f3b to
cd4d1a9
Compare
added 5 commits
January 31, 2024 22:40
* Improve psmap types, taken from a private eamuse server backend which had more complete mappings. * Move psmap terminator to enum * AVS error type: Supports improving expressiveness of the API interface * Add more property node related functions Add more AVS file system related functions These were previously missing and are required for various file system related tasks such as iterating directory trees, reading and writing files through the AVS file system for the upcoming launcher rework. Note that the AVS API broke with some mode flags after version 2.13.06.
Add all functions and their respective ordinals (and mangled names for documentation purpose) to all currently used AVS version.
This one was missing and is the actual correct version used for ddr-13. 2.13.04 was compatible, thus far, but there isn't any guarantee that they are actually 100% compatible (only konmai knows...).
Apparently forgotten to get updated to reflect the currently supported versions correctly.
Apparently also forgotten to reflect currently supported games.
icex2
force-pushed
the
pre-work-launcher-refactoring
branch
from
cd4d1a9 to
67cacd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from the large changeset that refactors launcher (see #277). See individual commits for details and reasoning.